mirror of
https://bitbucket.org/siakitem/my-pi.git
synced 2026-10-26 18:55:22 +00:00
feat(pi-hermes-memory): 导入上游 v0.9.10 源码快照
从官方 Git 仓库导入 chandra447/pi-hermes-memory 在 tag v0.9.10 （df624056a2e8c68bc89ba0a81e1c120856ec9665，2026-10-02）的源码快照。 本次仅导入源码，尚未接入组合包：package.json、加载顺序、依赖与权限策略 均未改动。 - 原样导入 src/、tests/、docs/、scripts/、README、CHANGELOG、PLAN、 AGENTS 与 LICENSE；该快照共 156 个上游文件。 - 剔除嵌套 .git、上游 .github 工作流、.ralph/、.claude/、node_modules、 覆盖率与构建产物。 - 新增中文 UPSTREAM.md，记录来源，以及启用前必须完成的待决事项： 在 pi-compaction 之前注册加载顺序、better-sqlite3 版本与根 allowScripts 对齐、strip-ansi 解析确认。 - 说明选择 tag 而非 main 的原因：导入时上游 main 已领先至 24fcd8ad26fc27badb8d7dbaf8034645de07b893（2026-10-11），选 tag 是为 对应一个已发布、可复现的版本。 尚未接线。启用前还需反转 tests/extension-load.test.ts 中"不得加载 Hermes"的断言，并同步 pi-tool-search 分组、权限策略与文档。 验证：快照 156 个上游文件全部导入，目录内仅多出 UPSTREAM.md 一份； 已确认与上游 main 内容存在差异，证明取的是 tag 而非 main。
This commit is contained in:
云服务部-叶林立
@@ -0,0 +1,529 @@
|
||||
/**
|
||||
* Unit tests for skill tool registration and execute function.
|
||||
*/
|
||||
|
||||
import { describe, it } from "node:test";
|
||||
import * as assert from "node:assert/strict";
|
||||
import { registerSkillTool, SKILL_MANAGE_TOOL_NAME } from "../../src/tools/skill-tool.js";
|
||||
import { SkillStore } from "../../src/store/skill-store.js";
|
||||
import * as path from "node:path";
|
||||
import * as os from "node:os";
|
||||
import * as fs from "node:fs/promises";
|
||||
|
||||
let ROOT_DIR = "";
|
||||
let GLOBAL_SKILLS_DIR = "";
|
||||
let PROJECT_SKILLS_DIR = "";
|
||||
|
||||
async function makeStore(withProject = true): Promise<SkillStore> {
|
||||
ROOT_DIR = await fs.mkdtemp(path.join(os.tmpdir(), "pi-skill-tool-test-"));
|
||||
GLOBAL_SKILLS_DIR = path.join(ROOT_DIR, "global-skills");
|
||||
PROJECT_SKILLS_DIR = path.join(ROOT_DIR, "project-skills");
|
||||
await fs.mkdir(GLOBAL_SKILLS_DIR, { recursive: true });
|
||||
if (withProject) await fs.mkdir(PROJECT_SKILLS_DIR, { recursive: true });
|
||||
|
||||
return new SkillStore({
|
||||
globalSkillsDir: GLOBAL_SKILLS_DIR,
|
||||
projectSkillsDir: withProject ? PROJECT_SKILLS_DIR : null,
|
||||
projectName: withProject ? "demo-project" : null,
|
||||
legacySkillsDir: path.join(ROOT_DIR, "legacy-skills"),
|
||||
migrationSentinelPath: path.join(ROOT_DIR, ".skill-migration"),
|
||||
});
|
||||
}
|
||||
|
||||
async function cleanup(): Promise<void> {
|
||||
try {
|
||||
await fs.rm(ROOT_DIR, { recursive: true, force: true });
|
||||
} catch {
|
||||
// ignore
|
||||
}
|
||||
}
|
||||
|
||||
describe("registerSkillTool", () => {
|
||||
it("registers tool with name 'skill_manage'", async () => {
|
||||
let captured: any;
|
||||
const mockPi = {
|
||||
registerTool: (def: any) => { captured = def; },
|
||||
} as any;
|
||||
|
||||
const store = await makeStore();
|
||||
registerSkillTool(mockPi, store);
|
||||
await cleanup();
|
||||
|
||||
assert.strictEqual(captured.name, SKILL_MANAGE_TOOL_NAME);
|
||||
assert.strictEqual(captured.label, "Skill Manager");
|
||||
assert.ok(captured.description.length > 0);
|
||||
assert.ok(captured.promptSnippet.length > 0);
|
||||
assert.ok(Array.isArray(captured.promptGuidelines));
|
||||
assert.ok(captured.parameters);
|
||||
});
|
||||
|
||||
it("create requires name, description, a body or structured fields, and scope", async () => {
|
||||
let captured: any;
|
||||
const mockPi = {
|
||||
registerTool: (def: any) => { captured = def; },
|
||||
} as any;
|
||||
|
||||
const store = await makeStore();
|
||||
registerSkillTool(mockPi, store);
|
||||
|
||||
let result = await captured.execute("tc-1", { action: "create", description: "desc", content: "body" }, undefined, undefined, undefined);
|
||||
assert.strictEqual(JSON.parse(result.content[0].text).success, false);
|
||||
|
||||
result = await captured.execute("tc-1", { action: "create", name: "test", content: "body" }, undefined, undefined, undefined);
|
||||
assert.strictEqual(JSON.parse(result.content[0].text).success, false);
|
||||
|
||||
result = await captured.execute("tc-1", { action: "create", name: "test", description: "desc" }, undefined, undefined, undefined);
|
||||
const missingBody = JSON.parse(result.content[0].text);
|
||||
assert.strictEqual(missingBody.success, false);
|
||||
assert.match(missingBody.error, /Either content or structured fields are required/i);
|
||||
|
||||
result = await captured.execute("tc-1", {
|
||||
action: "create",
|
||||
name: "test",
|
||||
description: "desc",
|
||||
content: "body",
|
||||
}, undefined, undefined, undefined);
|
||||
const missingScope = JSON.parse(result.content[0].text);
|
||||
assert.strictEqual(missingScope.success, false);
|
||||
assert.match(missingScope.error, /scope is required/i);
|
||||
|
||||
await cleanup();
|
||||
});
|
||||
|
||||
it("create succeeds with raw markdown content and returns skill_id", async () => {
|
||||
let captured: any;
|
||||
const mockPi = {
|
||||
registerTool: (def: any) => { captured = def; },
|
||||
} as any;
|
||||
|
||||
const store = await makeStore();
|
||||
registerSkillTool(mockPi, store);
|
||||
|
||||
const result = await captured.execute("tc-1", {
|
||||
action: "create",
|
||||
name: "test-skill",
|
||||
description: "A test skill",
|
||||
scope: "global",
|
||||
content: "## Procedure\n1. Do it",
|
||||
}, undefined, undefined, undefined);
|
||||
|
||||
const parsed = JSON.parse(result.content[0].text);
|
||||
assert.strictEqual(parsed.success, true);
|
||||
assert.strictEqual(parsed.skillId, "global:test-skill");
|
||||
assert.strictEqual(parsed.scope, "global");
|
||||
|
||||
await cleanup();
|
||||
});
|
||||
|
||||
it("create builds a valid skill body from structured fields", async () => {
|
||||
let captured: any;
|
||||
const mockPi = {
|
||||
registerTool: (def: any) => { captured = def; },
|
||||
} as any;
|
||||
|
||||
const store = await makeStore();
|
||||
registerSkillTool(mockPi, store);
|
||||
|
||||
const result = await captured.execute("tc-1", {
|
||||
action: "create",
|
||||
name: "debug-typescript-errors",
|
||||
description: "Debug TypeScript build failures in this repo",
|
||||
scope: "project",
|
||||
when_to_use: "Use when the repo's TypeScript build fails locally or in CI.",
|
||||
procedure_steps: [
|
||||
"Run pnpm tsc --noEmit to get the full error list.",
|
||||
"Fix dependency and config errors before leaf-module errors.",
|
||||
],
|
||||
pitfalls: [
|
||||
"Do not rely on editor-only diagnostics.",
|
||||
],
|
||||
verification_steps: [
|
||||
"pnpm tsc --noEmit exits successfully.",
|
||||
],
|
||||
}, undefined, undefined, undefined);
|
||||
|
||||
const parsed = JSON.parse(result.content[0].text);
|
||||
assert.strictEqual(parsed.success, true);
|
||||
|
||||
const created = await store.loadSkill(parsed.skillId);
|
||||
assert.match(created?.body || "", /## When to Use/);
|
||||
assert.match(created?.body || "", /## Procedure/);
|
||||
assert.match(created?.body || "", /1\. Run pnpm tsc --noEmit/);
|
||||
assert.match(created?.body || "", /## Pitfalls/);
|
||||
assert.match(created?.body || "", /## Verification/);
|
||||
|
||||
await cleanup();
|
||||
});
|
||||
|
||||
it("create supports explicit project scope", async () => {
|
||||
let captured: any;
|
||||
const mockPi = {
|
||||
registerTool: (def: any) => { captured = def; },
|
||||
} as any;
|
||||
|
||||
const store = await makeStore();
|
||||
registerSkillTool(mockPi, store);
|
||||
|
||||
const result = await captured.execute("tc-1", {
|
||||
action: "create",
|
||||
name: "release-app",
|
||||
description: "Release this app",
|
||||
scope: "project",
|
||||
content: "## Procedure\n1. Run pnpm build",
|
||||
}, undefined, undefined, undefined);
|
||||
|
||||
const parsed = JSON.parse(result.content[0].text);
|
||||
assert.strictEqual(parsed.success, true);
|
||||
assert.strictEqual(parsed.skillId, "project:demo-project:release-app");
|
||||
assert.strictEqual(parsed.scope, "project");
|
||||
|
||||
await cleanup();
|
||||
});
|
||||
|
||||
it("view without skill_id lists all skills", async () => {
|
||||
let captured: any;
|
||||
const mockPi = {
|
||||
registerTool: (def: any) => { captured = def; },
|
||||
} as any;
|
||||
|
||||
const store = await makeStore();
|
||||
await store.create("skill-a", "First", "body a");
|
||||
await store.create("skill-b", "Second", "body b", "project");
|
||||
registerSkillTool(mockPi, store);
|
||||
|
||||
const result = await captured.execute("tc-1", { action: "view" }, undefined, undefined, undefined);
|
||||
const parsed = JSON.parse(result.content[0].text);
|
||||
assert.strictEqual(parsed.success, true);
|
||||
assert.strictEqual(parsed.skills.length, 2);
|
||||
|
||||
await cleanup();
|
||||
});
|
||||
|
||||
it("view with skill_id returns full document", async () => {
|
||||
let captured: any;
|
||||
const mockPi = {
|
||||
registerTool: (def: any) => { captured = def; },
|
||||
} as any;
|
||||
|
||||
const store = await makeStore();
|
||||
const created = await store.create("my-skill", "A skill", "## Body content here");
|
||||
registerSkillTool(mockPi, store);
|
||||
|
||||
const result = await captured.execute("tc-1", { action: "view", skill_id: created.skillId }, undefined, undefined, undefined);
|
||||
const parsed = JSON.parse(result.content[0].text);
|
||||
assert.strictEqual(parsed.success, true);
|
||||
assert.strictEqual(parsed.name, "my-skill");
|
||||
assert.ok(parsed.body.includes("## Body content here"));
|
||||
|
||||
await cleanup();
|
||||
});
|
||||
|
||||
it("view with invalid skill_id returns error", async () => {
|
||||
let captured: any;
|
||||
const mockPi = {
|
||||
registerTool: (def: any) => { captured = def; },
|
||||
} as any;
|
||||
|
||||
const store = await makeStore();
|
||||
registerSkillTool(mockPi, store);
|
||||
|
||||
const result = await captured.execute("tc-1", { action: "view", skill_id: "global:missing" }, undefined, undefined, undefined);
|
||||
const parsed = JSON.parse(result.content[0].text);
|
||||
assert.strictEqual(parsed.success, false);
|
||||
assert.ok(parsed.error.includes("not found"));
|
||||
|
||||
await cleanup();
|
||||
});
|
||||
|
||||
it("patch requires skill_id, section, and content or structured fields", async () => {
|
||||
let captured: any;
|
||||
const mockPi = {
|
||||
registerTool: (def: any) => { captured = def; },
|
||||
} as any;
|
||||
|
||||
const store = await makeStore();
|
||||
registerSkillTool(mockPi, store);
|
||||
|
||||
let result = await captured.execute("tc-1", { action: "patch", section: "Procedure", content: "new" }, undefined, undefined, undefined);
|
||||
assert.strictEqual(JSON.parse(result.content[0].text).success, false);
|
||||
|
||||
result = await captured.execute("tc-1", { action: "patch", skill_id: "global:test", content: "new" }, undefined, undefined, undefined);
|
||||
assert.strictEqual(JSON.parse(result.content[0].text).success, false);
|
||||
|
||||
result = await captured.execute("tc-1", { action: "patch", skill_id: "global:test", section: "Procedure" }, undefined, undefined, undefined);
|
||||
assert.strictEqual(JSON.parse(result.content[0].text).success, false);
|
||||
|
||||
await cleanup();
|
||||
});
|
||||
|
||||
it("patch accepts structured procedure_steps for a section update", async () => {
|
||||
let captured: any;
|
||||
const mockPi = {
|
||||
registerTool: (def: any) => { captured = def; },
|
||||
} as any;
|
||||
|
||||
const store = await makeStore();
|
||||
const created = await store.create(
|
||||
"patch-me",
|
||||
"desc",
|
||||
"## Procedure\n1. Old way\n\n## Pitfalls\n- Keep me\n\n## Verification\n1. Still works",
|
||||
);
|
||||
registerSkillTool(mockPi, store);
|
||||
|
||||
const result = await captured.execute("tc-1", {
|
||||
action: "patch",
|
||||
skill_id: created.skillId,
|
||||
section: "Procedure",
|
||||
procedure_steps: ["Do the new first step", "Do the new second step"],
|
||||
}, undefined, undefined, undefined);
|
||||
|
||||
const parsed = JSON.parse(result.content[0].text);
|
||||
assert.strictEqual(parsed.success, true);
|
||||
|
||||
const doc = await store.loadSkill(created.skillId!);
|
||||
assert.match(doc!.body, /## Procedure\n1\. Do the new first step\n2\. Do the new second step/);
|
||||
assert.match(doc!.body, /## Pitfalls\n- Keep me/);
|
||||
assert.match(doc!.body, /## Verification\n1\. Still works/);
|
||||
assert.doesNotMatch(doc!.body, /Old way/);
|
||||
|
||||
await cleanup();
|
||||
});
|
||||
|
||||
it("patch rejects JSON object content strings", async () => {
|
||||
let captured: any;
|
||||
const mockPi = {
|
||||
registerTool: (def: any) => { captured = def; },
|
||||
} as any;
|
||||
|
||||
const store = await makeStore();
|
||||
const created = await store.create("patch-me", "desc", "## Procedure\n1. Keep");
|
||||
registerSkillTool(mockPi, store);
|
||||
|
||||
const result = await captured.execute("tc-1", {
|
||||
action: "patch",
|
||||
skill_id: created.skillId,
|
||||
section: "Procedure",
|
||||
content: '{"steps":["bad"]}',
|
||||
}, undefined, undefined, undefined);
|
||||
|
||||
const parsed = JSON.parse(result.content[0].text);
|
||||
assert.strictEqual(parsed.success, false);
|
||||
assert.match(parsed.error, /JSON object/i);
|
||||
assert.equal((await store.loadSkill(created.skillId!))!.version, 1);
|
||||
|
||||
await cleanup();
|
||||
});
|
||||
|
||||
it("patch coerces JSON array content strings into Markdown lists", async () => {
|
||||
let captured: any;
|
||||
const mockPi = {
|
||||
registerTool: (def: any) => { captured = def; },
|
||||
} as any;
|
||||
|
||||
const store = await makeStore();
|
||||
const created = await store.create("patch-me", "desc", "## Pitfalls\n- old");
|
||||
registerSkillTool(mockPi, store);
|
||||
|
||||
const result = await captured.execute("tc-1", {
|
||||
action: "patch",
|
||||
skill_id: created.skillId,
|
||||
section: "Pitfalls",
|
||||
content: '["Do not skip verification", "Do not wipe other sections"]',
|
||||
}, undefined, undefined, undefined);
|
||||
|
||||
const parsed = JSON.parse(result.content[0].text);
|
||||
assert.strictEqual(parsed.success, true);
|
||||
|
||||
const doc = await store.loadSkill(created.skillId!);
|
||||
assert.match(doc!.body, /## Pitfalls\n- Do not skip verification\n- Do not wipe other sections/);
|
||||
assert.doesNotMatch(doc!.body, /\[\"Do not skip verification\"/);
|
||||
|
||||
await cleanup();
|
||||
});
|
||||
|
||||
it("update requires skill_id", async () => {
|
||||
let captured: any;
|
||||
const mockPi = {
|
||||
registerTool: (def: any) => { captured = def; },
|
||||
} as any;
|
||||
|
||||
const store = await makeStore();
|
||||
registerSkillTool(mockPi, store);
|
||||
|
||||
const result = await captured.execute("tc-1", { action: "update", description: "new desc" }, undefined, undefined, undefined);
|
||||
const parsed = JSON.parse(result.content[0].text);
|
||||
assert.strictEqual(parsed.success, false);
|
||||
assert.ok(parsed.error.includes("skill_id"));
|
||||
|
||||
await cleanup();
|
||||
});
|
||||
|
||||
it("update aliases to full skill rewrite", async () => {
|
||||
let captured: any;
|
||||
const mockPi = {
|
||||
registerTool: (def: any) => { captured = def; },
|
||||
} as any;
|
||||
|
||||
const store = await makeStore();
|
||||
const created = await store.create("my-skill", "Old desc", "## Old body", "global");
|
||||
registerSkillTool(mockPi, store);
|
||||
|
||||
const result = await captured.execute("tc-1", {
|
||||
action: "update",
|
||||
skill_id: created.skillId,
|
||||
description: "New desc",
|
||||
content: "## New body",
|
||||
}, undefined, undefined, undefined);
|
||||
|
||||
const parsed = JSON.parse(result.content[0].text);
|
||||
assert.strictEqual(parsed.success, true);
|
||||
|
||||
const updated = await store.loadSkill(created.skillId!);
|
||||
assert.strictEqual(updated?.description, "New desc");
|
||||
assert.match(updated?.body || "", /New body/);
|
||||
|
||||
await cleanup();
|
||||
});
|
||||
|
||||
it("update can rebuild the body from structured fields", async () => {
|
||||
let captured: any;
|
||||
const mockPi = {
|
||||
registerTool: (def: any) => { captured = def; },
|
||||
} as any;
|
||||
|
||||
const store = await makeStore();
|
||||
const created = await store.create("my-skill", "Old desc", "## Old body", "global");
|
||||
registerSkillTool(mockPi, store);
|
||||
|
||||
const result = await captured.execute("tc-1", {
|
||||
action: "update",
|
||||
skill_id: created.skillId,
|
||||
description: "New desc",
|
||||
when_to_use: "Use when validating the new rewrite path.",
|
||||
procedure_steps: ["Perform the new sequence."],
|
||||
verification_steps: ["Confirm the new sequence works."],
|
||||
}, undefined, undefined, undefined);
|
||||
|
||||
const parsed = JSON.parse(result.content[0].text);
|
||||
assert.strictEqual(parsed.success, true);
|
||||
|
||||
const updated = await store.loadSkill(created.skillId!);
|
||||
assert.match(updated?.body || "", /## When to Use/);
|
||||
assert.match(updated?.body || "", /Perform the new sequence/);
|
||||
assert.match(updated?.body || "", /No notable pitfalls recorded yet/);
|
||||
|
||||
await cleanup();
|
||||
});
|
||||
|
||||
it("legacy edit alias still rewrites the skill", async () => {
|
||||
let captured: any;
|
||||
const mockPi = {
|
||||
registerTool: (def: any) => { captured = def; },
|
||||
} as any;
|
||||
|
||||
const store = await makeStore();
|
||||
const created = await store.create("legacy-skill", "Old desc", "## Old body", "global");
|
||||
registerSkillTool(mockPi, store);
|
||||
|
||||
const result = await captured.execute("tc-1", {
|
||||
action: "edit",
|
||||
skill_id: created.skillId,
|
||||
description: "Legacy desc",
|
||||
content: "## Legacy body",
|
||||
}, undefined, undefined, undefined);
|
||||
|
||||
const parsed = JSON.parse(result.content[0].text);
|
||||
assert.strictEqual(parsed.success, true);
|
||||
|
||||
const updated = await store.loadSkill(created.skillId!);
|
||||
assert.strictEqual(updated?.description, "Legacy desc");
|
||||
assert.match(updated?.body || "", /Legacy body/);
|
||||
|
||||
await cleanup();
|
||||
});
|
||||
|
||||
it("delete requires skill_id", async () => {
|
||||
let captured: any;
|
||||
const mockPi = {
|
||||
registerTool: (def: any) => { captured = def; },
|
||||
} as any;
|
||||
|
||||
const store = await makeStore();
|
||||
registerSkillTool(mockPi, store);
|
||||
|
||||
const result = await captured.execute("tc-1", { action: "delete" }, undefined, undefined, undefined);
|
||||
const parsed = JSON.parse(result.content[0].text);
|
||||
assert.strictEqual(parsed.success, false);
|
||||
assert.ok(parsed.error.includes("skill_id"));
|
||||
|
||||
await cleanup();
|
||||
});
|
||||
|
||||
it("unknown action returns error", async () => {
|
||||
let captured: any;
|
||||
const mockPi = {
|
||||
registerTool: (def: any) => { captured = def; },
|
||||
} as any;
|
||||
|
||||
const store = await makeStore();
|
||||
registerSkillTool(mockPi, store);
|
||||
|
||||
const result = await captured.execute("tc-1", { action: "explode" }, undefined, undefined, undefined);
|
||||
const parsed = JSON.parse(result.content[0].text);
|
||||
assert.strictEqual(parsed.success, false);
|
||||
assert.ok(parsed.error.includes("Unknown action"));
|
||||
|
||||
await cleanup();
|
||||
});
|
||||
});
|
||||
|
||||
describe("skill discovery wording (issue #244)", () => {
|
||||
async function captureTool(): Promise<any> {
|
||||
let captured: any;
|
||||
const mockPi = {
|
||||
registerTool: (def: any) => { captured = def; },
|
||||
} as any;
|
||||
|
||||
const store = await makeStore();
|
||||
registerSkillTool(mockPi, store);
|
||||
return captured;
|
||||
}
|
||||
|
||||
it("description param carries the discovery requirement, when_to_use notes the index boundary", async () => {
|
||||
const captured = await captureTool();
|
||||
const props = captured.parameters.properties;
|
||||
|
||||
const descriptionHelp: string = props.description.description;
|
||||
assert.match(descriptionHelp, /Pi indexes skills by this field alone/);
|
||||
assert.match(descriptionHelp, /trigger signals/);
|
||||
assert.match(descriptionHelp, /1024/);
|
||||
|
||||
const whenToUseHelp: string = props.when_to_use.description;
|
||||
assert.match(whenToUseHelp, /does not participate in Pi's skill index/);
|
||||
|
||||
await cleanup();
|
||||
});
|
||||
|
||||
it("tool description states the mechanism and demonstrates it in the example", async () => {
|
||||
const captured = await captureTool();
|
||||
const text: string = captured.description;
|
||||
|
||||
assert.match(text, /Pi indexes skills by this field alone/);
|
||||
assert.match(text, /discoverable trigger signals belong in description/);
|
||||
assert.match(text, /"description": "Debug TypeScript build failures in this repo: tsc --noEmit errors/);
|
||||
|
||||
await cleanup();
|
||||
});
|
||||
|
||||
it("prompt guidelines point trigger signals at description", async () => {
|
||||
const captured = await captureTool();
|
||||
const guidelines: string[] = captured.promptGuidelines;
|
||||
|
||||
assert.ok(
|
||||
guidelines.some((g) => /Put the trigger signals a user would type in 'description'/.test(g)),
|
||||
"expected a guideline directing trigger signals to description",
|
||||
);
|
||||
|
||||
await cleanup();
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user