mirror of
https://bitbucket.org/siakitem/my-pi.git
synced 2026-10-26 10:45:22 +00:00
feat(pi-permission-system): AutoReview 改为跟随主模型的对话式工具调用审查
AutoReview: - 审查器回到 Codex Guardian 风格的对话式审查,默认跟随会话当前主模型 (每次审查实时读取 ctx.model);provider/model 必须同时设置才固定审查 模型,只设其一视为配置错误并转人工。 - 结论只通过 approve / reject 两个工具给出,参数仅 reason;不强制 toolChoice,正文文本(即使是合法 JSON)一律忽略。 - approve 自动放行;reject 转人工并在弹窗显示理由(标注模型生成)。 超时、Provider 错误、截断、未调用工具、多次调用、参数无效等异常同样 转人工,并附固定的系统说明;用户按 Esc 中止时直接拒绝。 - 模型调用改为 modelRegistry.streamSimple(...).result():Pi 1.3.0 面向 扩展的 ModelRegistry 没有 completeSimple,原写法在真实环境中每次都会 转人工。 - 对话记录保留可信度标注;工具结果在有更短的 pi-compaction 摘要时替换 为摘要;token 估算改为非 ASCII 字符按 1 token 计;预算可配置。 - 同一条用户消息内完全相同的请求只缓存 approve 结论。 - 默认 reasoning low、总超时 30 秒、最多 2 次尝试、maxOutputTokens 4000。 删除: - 未发布过的 TypeSafe Jev 分类器实现、DenialCircuitBreaker。 - 整个 annotator 机制(model-explanation、注册表、registerAnnotator、 provider-timeout);annotators 配置键保留为已弃用并忽略,避免旧配置 被拒绝。 测试: - 新增 reviewer / transcript / 弹窗说明 / 默认配置测试;清理重复、恒真 或只测实现细节的旧测试。 - 使用 deepseek-v4.1-flash 实测 5 个场景各 5 次,25 次结论全部符合预期。 Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This commit is contained in:
co-authored by
Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
parent
dec48dab6d
commit
7e6a8faae1
@@ -1,5 +1,4 @@
|
||||
import { afterEach, describe, expect, test, vi } from "vitest";
|
||||
import { SUBAGENT_ENV_HINT_KEYS } from "#src/authority/permission-forwarding";
|
||||
import {
|
||||
isRegisteredSubagentChild,
|
||||
isSubagentExecutionContext,
|
||||
@@ -258,23 +257,6 @@ describe("isSubagentExecutionContext — env hint detection", () => {
|
||||
).toBe(true);
|
||||
});
|
||||
|
||||
test("covers all declared SUBAGENT_ENV_HINT_KEYS", () => {
|
||||
// Verify the keys we test match what the module declares.
|
||||
expect(SUBAGENT_ENV_HINT_KEYS).toContain("PI_IS_SUBAGENT");
|
||||
expect(SUBAGENT_ENV_HINT_KEYS).toContain("PI_SUBAGENT_SESSION_ID");
|
||||
expect(SUBAGENT_ENV_HINT_KEYS).toContain("PI_AGENT_ROUTER_SUBAGENT");
|
||||
// nicobailon/pi-subagents
|
||||
expect(SUBAGENT_ENV_HINT_KEYS).toContain("PI_SUBAGENT_CHILD");
|
||||
expect(SUBAGENT_ENV_HINT_KEYS).toContain("PI_SUBAGENT_RUN_ID");
|
||||
expect(SUBAGENT_ENV_HINT_KEYS).toContain("PI_SUBAGENT_CHILD_AGENT");
|
||||
expect(SUBAGENT_ENV_HINT_KEYS).toContain("PI_SUBAGENT_DEPTH");
|
||||
// HazAT/pi-interactive-subagents
|
||||
expect(SUBAGENT_ENV_HINT_KEYS).toContain("PI_SUBAGENT_NAME");
|
||||
expect(SUBAGENT_ENV_HINT_KEYS).toContain("PI_SUBAGENT_ID");
|
||||
expect(SUBAGENT_ENV_HINT_KEYS).toContain("PI_SUBAGENT_SESSION");
|
||||
expect(SUBAGENT_ENV_HINT_KEYS).toContain("PI_SUBAGENT_ACTIVITY_FILE");
|
||||
});
|
||||
|
||||
test("returns false when env hint value is empty string", () => {
|
||||
vi.stubEnv("PI_IS_SUBAGENT", "");
|
||||
expect(
|
||||
@@ -471,19 +453,6 @@ describe("isSubagentExecutionContext — registry detection", () => {
|
||||
).toBe(true);
|
||||
});
|
||||
|
||||
test("returns true when registered session has a parentSessionId", () => {
|
||||
const registry = new SubagentSessionRegistry();
|
||||
registry.register(childSessionId, { parentSessionId: "parent-123" });
|
||||
expect(
|
||||
isSubagentExecutionContext(
|
||||
makeCtx(outsideDir, childSessionId),
|
||||
subagentRoot,
|
||||
posixPathFlavor,
|
||||
registry,
|
||||
),
|
||||
).toBe(true);
|
||||
});
|
||||
|
||||
test("returns false when registry is provided but session id is not registered", () => {
|
||||
const registry = new SubagentSessionRegistry();
|
||||
expect(
|
||||
@@ -508,22 +477,6 @@ describe("isSubagentExecutionContext — registry detection", () => {
|
||||
).toBe(false);
|
||||
});
|
||||
|
||||
test("registry check takes priority over env var detection", () => {
|
||||
// Registry says registered; env var not set — should still return true.
|
||||
const registry = new SubagentSessionRegistry();
|
||||
registry.register(childSessionId, {});
|
||||
// Confirm no env var is set
|
||||
expect(process.env.PI_IS_SUBAGENT).toBeUndefined();
|
||||
expect(
|
||||
isSubagentExecutionContext(
|
||||
makeCtx(outsideDir, childSessionId),
|
||||
subagentRoot,
|
||||
posixPathFlavor,
|
||||
registry,
|
||||
),
|
||||
).toBe(true);
|
||||
});
|
||||
|
||||
test("unregistered session falls through to env var detection", () => {
|
||||
vi.stubEnv("PI_IS_SUBAGENT", "true");
|
||||
const registry = new SubagentSessionRegistry(); // empty — childSessionId not registered
|
||||
@@ -537,11 +490,4 @@ describe("isSubagentExecutionContext — registry detection", () => {
|
||||
),
|
||||
).toBe(true);
|
||||
});
|
||||
|
||||
test("no registry passed — existing behaviour unchanged", () => {
|
||||
// Ensure the parameter is truly optional (no registry arg)
|
||||
expect(
|
||||
isSubagentExecutionContext(makeCtx(null), subagentRoot, posixPathFlavor),
|
||||
).toBe(false);
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user