PermissionPrompter

src/authority/permission-prompter.ts

Responsibility

PermissionPrompter brackets the ask-path flow with review-log entries and delegates the live decision to the selected Authorizer (#555):

Review log — waiting — write permission_request.waiting before the authorizer is consulted.
authorizer.authorize(details) — the selected Authorizer (LocalUserAuthorizer, ParentAuthorizer, or DenyingAuthorizer) resolves the decision. The UI-prompt broadcast and the UI/forwarding branching this class previously owned now live on the individual Authorizer implementations — see architecture.md's authority model.
Review log — outcome — write permission_request.approved or permission_request.denied with the final decision state, any denial reason, and the decision's decidedBy provenance (#726). The denied entry's resolution is the decision state, or confirmation_unavailable when the decision carries that marker — a DenyingAuthorizer denial, i.e. no live authority was reachable (a no-UI, non-subagent session) (#556).

Only the outcome entries carry decidedBy; the waiting entry does not, because nothing has decided yet and a null there would read as decided-by-nobody. The prompter records what the decision states rather than deriving it — which is what lets one entry distinguish a human at the dialog, a chain link, an unreachable authority, and another session's answer, where the shape alone cannot.

Yolo-mode auto-approval is resolved upstream: at the composition stage (PermissionManager.check's rewriteAsksToYolo) for a rule-driven ask, and at GateRunner's auto-approve fast path (resolveYoloGrant) for an ask synthesized after resolution, which no rule rewrite can reach (#712). An ask never reaches this class under yolo, so PermissionPrompter has no yolo-mode knowledge.

Why a class instead of a free function

The previous implementation was promptPermission(runtime, forwardingDeps, ctx, details) in runtime.ts. Adding a new field to PromptPermissionDetails (e.g. sessionLabel in #51) required touching four files: types.ts → runtime.ts → polling.ts → index.ts.

With PermissionPrompter, adding a new field touches two files:

src/authority/permission-prompter.ts — add the field to PromptPermissionDetails.
The Authorizer implementation(s) that read the new field — currently local-user-authorizer.ts and approval-escalator.ts (ParentAuthorizer).

Handler code and wiring in index.ts are unaffected.

Interfaces

interface PermissionPrompterApi {
  prompt(authorizer: Authorizer, details: PromptPermissionDetails): Promise<PermissionPromptDecision>;
}

interface PermissionPrompterDeps {
  logger: ReviewLogger; // review-log bracketing only
}

PermissionPrompterApi is the narrow seam AuthorizerSelection depends on (not the concrete class) — a private field on the concrete class would create a nominal brand a structural test mock ({ prompt: vi.fn() }) cannot satisfy without a cast.

Authorizer is the single live-authority role, defined in src/authority/authorizer.ts:

interface Authorizer {
  authorize(details: PromptPermissionDetails): Promise<PermissionPromptDecision>;
}

Relationship to the Authorizer spine

PermissionPrompter no longer assembles or holds any UI/forwarding dependency — it receives the already-selected Authorizer as a call-time argument from AuthorizerSelection.prompt(details), rather than threading ExtensionContext through a forwarder.requestApproval(ctx, …) call. AuthorizerSelection (the rewrite of the former PromptingGateway) owns the selection: selectAuthorizer(ctx, deps) runs once per session activation and returns a SelectedAuthority for that context — the terminal (LocalUserAuthorizer when ctx.hasUI, ParentAuthorizer when the context is a no-UI subagent, DenyingAuthorizer otherwise) plus adjudicatesLocally, which is false for the relaying ParentAuthorizer arm so that node resolves no chain links (one chain per node, ADR 0007 §7).

Wiring

PermissionPrompter is instantiated once in piPermissionSystemExtension() (src/index.ts) and injected into AuthorizerSelection:

const prompter = new PermissionPrompter({ logger });

const authorizerSelection = new AuthorizerSelection({
  detection: subagentDetection,
  events: pi.events,
  requestPermissionDecisionFromUi,
  forwardingDir: paths.forwardingDir,
  registry: subagentRegistry,
  logger,
  prompter,
});

authorizerSelection implements AskEscalator and is passed to both PermissionSession (as the activate/deactivate lifecycle) and GateRunner (as the escalate(details) ask-escalation role). GateRunner calls this.prompter.escalate(details) for every ask — there is no canConfirm() pre-check (#556 dissolved it); the selected Authorizer always answers, the DenyingAuthorizer by denying with the confirmationUnavailable marker. The Authorizer spine is entirely behind that seam.

5.3 KiB Raw Blame History