Files
my-pi/pi-permission-system/src/auto-review/reviewer.ts
T
云服务部-叶林立 cdd91b3f8b feat: 移除 Codex Fast mode 与 AutoReview 后台分析,模型改为配置驱动
移除 pi-extension-codex-fast-mode:
- 删除整个扩展目录;同步清理根 package.json 的 files / pi.extensions /
  dependencies 条目、package-lock.json、tests/extension-load.test.ts 断言
  与文档章节。
- pi-minimal-footer 的 Fast on 渲染是该扩展的唯一消费者。扩展移除后 accent
  分支不再有生产者,collectFooterStatusItems 简化为直接返回非空状态字符串,
  去掉 FooterStatusItem 与 accent 标志,避免留下死代码。

移除 500 次裁决后的后台分析体系:
- 删除 analysis-agent.ts(192 行)与 ledger.ts(296 行),以及对应的
  auto-review-runtime / auto-review-ledger 测试。
- runtime.ts 由 177 行收敛到 85 行:安装选项缩为 { service, config };删除
  handleAgentSettled 与 agent_settled 注册;保留 session_start / turn_start
  (denial circuit breaker 属安全语义)/ session_shutdown。
- 删除 analysis 配置键:config、extension-config、config-schema、生成的
  permissions.schema.json 与种子配置。
- 删除 reviewer 的 onDecision 回调(唯一消费者是 ledger)。
- 删除迁移机制 scripts/migrate-permission-policy.mjs、其测试与 update.sh 中
  46 行 migrate_permission_policy 接线。种子部署保持“目标缺失才写入”,已存在
  的 policy.jsonc 永不被覆盖。

AutoReview 模型改为纯配置驱动:
- 删除 DEFAULT_PROVIDER / DEFAULT_MODEL 常量与 findCodexTemplate 合成逻辑;
  model.ts 由 65 行收敛到 48 行。
- provider / model 任一缺失时返回新增失败类别 model-unconfigured 并 defer 到
  人工审批;provider 未注册或模型未发布同样 defer。
- reasoning 不再有默认常量,完全由配置决定。
- session_start 在 auto-review 已列入 authorizerChain 且 provider/model 未配齐
  时 ui.notify 提示一次,避免不使用 AutoReview 的用户被打扰。
- 种子 autoReview 只保留 enabled,provider/model/reasoning 由用户按本机实际
  可用的模型填写。

破坏性变更:analysis 键已从 strictObject schema 删除,任何仍带该键的
policy.jsonc 会使整份配置被拒(fail-closed 到全 ask)。这是刻意的变更,已由
config-loader 测试固定,防止将来无声放宽。

测试:
- 新增 auto-review-model.test.ts(7 例),覆盖此前完全缺失的模型解析:真实
  命中、未配置、provider 未知、模型未发布,以及不再合成替代模型。
- 重写 auto-review-runtime.test.ts(6 例):authorizer 注册、未配置时提示
  一次、已配置 / disabled / 无 UI / 不在 chain 时静默。
- config-loader.test.ts 新增 2 例:带 analysis 的旧配置被拒且 fail-closed、
  autoReview 逐字段合并。
- composition-root.test.ts 的 EXPECTED_HANDLERS 移除 agent_settled。

文档:AGENTS.md、README.md、pi-permission-system 的 README / CHANGELOG /
configuration.md / architecture.md / auto-review UPSTREAM.md。

验证:pi-permission-system 的 typecheck、2577 个测试与 build 全部通过;根 50
个测试通过;schema 重新生成无漂移;新种子通过 schema 校验;5 个脚本 sh -n
通过;git diff --check 无空白问题。未安装 shellcheck;未执行真实 pi install /
update(属外部写操作)。
2026-10-14 08:15:13 -07:00

384 lines
11 KiB
TypeScript

import type { DenialCircuitBreaker } from './circuit-breaker.js'
import type { AutoReviewConfig } from './config.js'
import type { ReviewModelRegistry } from './model.js'
import type { TranscriptStats } from './transcript.js'
import type { ReviewAssessment } from './verdict.js'
import type { AssistantMessage, Provider, SimpleStreamOptions } from '@earendil-works/pi-ai'
import type { SessionManager } from '@earendil-works/pi-coding-agent'
import type { Authorizer, AuthorizerLog, PromptPermissionDetails } from '../service.js'
import { resolveReviewModel } from './model.js'
import { POLICY_REVISION } from './policy.js'
import { buildReviewPrompt } from './prompt.js'
import { renderTranscript } from './transcript.js'
import { parseReviewAssessment } from './verdict.js'
const DEFAULT_MAX_ATTEMPTS = 3
const DEFAULT_RETRY_DELAYS_MS = [250, 1_000]
const MAX_OUTPUT_TOKENS = 1_000
const DECISION_EVENT = 'auto_review.decision'
const FAILURE_EVENT = 'auto_review.failure'
const CIRCUIT_OPEN_EVENT = 'auto_review.circuit_open'
type FailureCategory =
| 'model-unconfigured'
| 'provider-unresolved'
| 'model-unresolved'
| 'auth-unresolved'
| 'provider-error'
| 'invalid-response'
| 'timeout'
| 'cancelled'
| 'internal-error'
export interface ReviewerRuntime {
config: AutoReviewConfig
registry: ReviewModelRegistry
sessionManager: Pick<SessionManager, 'getBranch'>
circuitBreaker: DenialCircuitBreaker
sessionSignal?: AbortSignal
}
export interface ReviewerDependencies {
now?: () => number
sleep?: (milliseconds: number, signal: AbortSignal) => Promise<void>
maxAttempts?: number
retryDelaysMs?: number[]
}
interface ContextDiagnostics extends TranscriptStats {
policyRevision: string
contextSource: 'active-branch'
}
interface Failure {
category: FailureCategory
contextDiagnostics?: ContextDiagnostics
}
interface ReviewCallResult {
assessment: ReviewAssessment
contextDiagnostics: ContextDiagnostics
}
function buildContextDiagnostics(stats: TranscriptStats): ContextDiagnostics {
return {
policyRevision: POLICY_REVISION,
contextSource: 'active-branch',
...stats,
}
}
function abortError(): Error {
const error = new Error('operation aborted')
error.name = 'AbortError'
return error
}
async function defaultSleep(milliseconds: number, signal: AbortSignal): Promise<void> {
if (milliseconds <= 0) {
return Promise.resolve()
}
return new Promise((resolve, reject) => {
if (signal.aborted) {
reject(abortError())
return
}
const timer = setTimeout(resolve, milliseconds)
signal.addEventListener(
'abort',
() => {
clearTimeout(timer)
reject(abortError())
},
{ once: true },
)
})
}
async function raceWithSignal<T>(promise: Promise<T>, signal: AbortSignal): Promise<T> {
if (signal.aborted) {
return Promise.reject(abortError())
}
return new Promise((resolve, reject) => {
const onAbort = (): void => reject(abortError())
signal.addEventListener('abort', onAbort, { once: true })
promise.then(
value => {
signal.removeEventListener('abort', onAbort)
resolve(value)
},
(error: unknown) => {
signal.removeEventListener('abort', onAbort)
reject(error)
},
)
})
}
function responseText(message: AssistantMessage): string {
return message.content
.filter((block): block is Extract<(typeof message.content)[number], { type: 'text' }> => block.type === 'text')
.map(block => block.text)
.join('')
.trim()
}
function buildStreamOptions(
runtime: ReviewerRuntime,
signal: AbortSignal,
timeoutMs: number,
auth: {
apiKey?: string
headers?: SimpleStreamOptions['headers']
env?: Record<string, string>
},
reasoning: boolean,
): SimpleStreamOptions {
const options: SimpleStreamOptions = {
maxRetries: 0,
maxTokens: MAX_OUTPUT_TOKENS,
signal,
timeoutMs,
}
if (auth.apiKey !== undefined) {
options.apiKey = auth.apiKey
}
if (auth.headers !== undefined) {
options.headers = auth.headers
}
if (auth.env !== undefined) {
options.env = auth.env
}
if (reasoning && runtime.config.reasoning !== undefined && runtime.config.reasoning !== 'off') {
options.reasoning = runtime.config.reasoning
}
return options
}
async function callProvider(
provider: Provider,
model: Parameters<Provider['streamSimple']>[0],
systemPrompt: string,
userPrompt: string,
options: SimpleStreamOptions,
): Promise<AssistantMessage> {
const stream = provider.streamSimple(
model,
{
systemPrompt,
messages: [
{
role: 'user',
content: userPrompt,
timestamp: Date.now(),
},
],
},
options,
)
return stream.result()
}
function writeFailure(
log: AuthorizerLog,
runtime: ReviewerRuntime,
details: PromptPermissionDetails,
failure: Failure,
durationMs: number,
): void {
const common = {
requestId: details.requestId,
provider: runtime.config.provider,
model: runtime.config.model,
outcome: 'defer',
errorCategory: failure.category,
durationMs,
...failure.contextDiagnostics,
}
log.review(DECISION_EVENT, common)
log.debug(FAILURE_EVENT, common)
}
function tryWriteFailure(
log: AuthorizerLog,
runtime: ReviewerRuntime,
details: PromptPermissionDetails,
failure: Failure,
durationMs: number,
): void {
try {
writeFailure(log, runtime, details, failure, durationMs)
} catch {
// Permission review failures must not escape into the fail-closed tool boundary.
}
}
function elapsedMilliseconds(now: () => number, startedAt: number): number {
try {
return Math.max(0, now() - startedAt)
} catch {
return 0
}
}
async function runReview(
runtime: ReviewerRuntime,
details: PromptPermissionDetails,
dependencies: Required<Pick<ReviewerDependencies, 'now' | 'sleep' | 'maxAttempts' | 'retryDelaysMs'>>,
): Promise<ReviewCallResult | Failure> {
const startedAt = dependencies.now()
const timeoutController = new AbortController()
const timeout = setTimeout(() => timeoutController.abort(), runtime.config.timeoutMs)
const signal =
runtime.sessionSignal === undefined
? timeoutController.signal
: AbortSignal.any([timeoutController.signal, runtime.sessionSignal])
try {
const transcript = renderTranscript(runtime.sessionManager.getBranch())
const contextDiagnostics = buildContextDiagnostics(transcript.stats)
const failure = (category: FailureCategory): Failure => ({ category, contextDiagnostics })
const resolved = resolveReviewModel(runtime.registry, runtime.config)
if (!resolved.ok) {
return failure(resolved.category)
}
let auth
try {
auth = await raceWithSignal(runtime.registry.getApiKeyAndHeaders(resolved.value.model), signal)
} catch {
if (signal.aborted) {
return failure(timeoutController.signal.aborted ? 'timeout' : 'cancelled')
}
return failure('auth-unresolved')
}
if (!auth.ok) {
return failure('auth-unresolved')
}
const prompt = buildReviewPrompt(runtime.config, transcript, details)
for (let attempt = 1; attempt <= dependencies.maxAttempts; attempt += 1) {
try {
const remainingMs = Math.max(1, runtime.config.timeoutMs - (dependencies.now() - startedAt))
const message = await raceWithSignal(
callProvider(
resolved.value.provider,
resolved.value.model,
prompt.systemPrompt,
prompt.userPrompt,
buildStreamOptions(runtime, signal, remainingMs, auth, resolved.value.model.reasoning),
),
signal,
)
if (message.stopReason === 'error' || message.stopReason === 'aborted') {
throw new Error(message.errorMessage ?? message.stopReason)
}
try {
return {
assessment: parseReviewAssessment(responseText(message)),
contextDiagnostics,
}
} catch {
return failure('invalid-response')
}
} catch {
if (signal.aborted) {
return failure(timeoutController.signal.aborted ? 'timeout' : 'cancelled')
}
if (attempt >= dependencies.maxAttempts) {
return failure('provider-error')
}
const delay = dependencies.retryDelaysMs[attempt - 1] ?? dependencies.retryDelaysMs.at(-1) ?? 0
try {
await dependencies.sleep(delay, signal)
} catch {
return failure(timeoutController.signal.aborted ? 'timeout' : 'cancelled')
}
}
}
return failure('provider-error')
} finally {
clearTimeout(timeout)
}
}
export function createPermissionReviewer(
runtime: ReviewerRuntime,
reviewerDependencies: ReviewerDependencies = {},
): Authorizer['authorize'] {
const dependencies = {
now: reviewerDependencies.now ?? Date.now,
sleep: reviewerDependencies.sleep ?? defaultSleep,
maxAttempts: reviewerDependencies.maxAttempts ?? DEFAULT_MAX_ATTEMPTS,
retryDelaysMs: reviewerDependencies.retryDelaysMs ?? DEFAULT_RETRY_DELAYS_MS,
}
return async (details, _query, log) => {
let startedAt = 0
try {
startedAt = dependencies.now()
if (runtime.circuitBreaker.isOpen()) {
const reason =
'Automatic permission review rejected too many requests in this turn. Ask the user for explicit approval before retrying.'
log.review(CIRCUIT_OPEN_EVENT, {
requestId: details.requestId,
provider: runtime.config.provider,
model: runtime.config.model,
outcome: 'deny',
durationMs: 0,
errorCategory: 'circuit-open',
})
return { kind: 'deny', reason }
}
const result = await runReview(runtime, details, dependencies)
const durationMs = elapsedMilliseconds(dependencies.now, startedAt)
if ('category' in result) {
runtime.circuitBreaker.recordNonDenial()
writeFailure(log, runtime, details, result, durationMs)
return { kind: 'defer' }
}
const { assessment, contextDiagnostics } = result
log.review(DECISION_EVENT, {
requestId: details.requestId,
provider: runtime.config.provider,
model: runtime.config.model,
riskLevel: assessment.riskLevel,
userAuthorization: assessment.userAuthorization,
outcome: assessment.outcome,
durationMs,
...contextDiagnostics,
})
if (assessment.outcome === 'allow') {
runtime.circuitBreaker.recordNonDenial()
return { kind: 'allow' }
}
runtime.circuitBreaker.recordDenied()
return {
kind: 'deny',
reason: `Automatic permission review denied this action (risk: ${assessment.riskLevel}, authorization: ${assessment.userAuthorization}): ${assessment.rationale}`,
}
} catch {
try {
runtime.circuitBreaker.recordNonDenial()
} catch {
// Returning defer remains the safe fallback even if local state is unavailable.
}
tryWriteFailure(
log,
runtime,
details,
{ category: 'internal-error' },
elapsedMilliseconds(dependencies.now, startedAt),
)
return { kind: 'defer' }
}
}
}