my-pi/tests/extension-load.test.ts

import assert from "node:assert/strict";
import { existsSync } from "node:fs";
import { mkdir, mkdtemp, readFile } from "node:fs/promises";
import { tmpdir } from "node:os";
import { dirname, join, resolve } from "node:path";
import { fileURLToPath } from "node:url";
import { spawnSync } from "node:child_process";
import test from "node:test";

const repositoryRoot = resolve(dirname(fileURLToPath(import.meta.url)), "..");
const hasPi = spawnSync("pi", ["--version"], { encoding: "utf8" }).status === 0;

test("enabled subagents wrapper loads with its bundle-owned mandatory permission entry", { skip: !hasPi }, async () => {
  const packageJson = JSON.parse(await readFile(join(repositoryRoot, "package.json"), "utf8")) as {
    dependencies: Record<string, string>;
    files: string[];
    pi: { extensions: string[] };
  };
  assert.ok(packageJson.files.includes("pi-subagents"));
  assert.equal(packageJson.dependencies["@tintinweb/pi-subagents"], "file:./pi-subagents");
  assert.ok(
    packageJson.pi.extensions.includes("./extensions/subagents.ts"),
    "the bundle must default-load the locally maintained subagents wrapper",
  );

  const home = await mkdtemp(join(tmpdir(), "my-pi-subagents-wrapper-load-"));
  const result = spawnSync(
    "pi",
    ["--no-extensions", "-e", join(repositoryRoot, "extensions", "subagents.ts"), "--mode", "rpc"],
    {
      encoding: "utf8",
      timeout: 60_000,
      env: {
        ...process.env,
        HOME: home,
        XDG_CONFIG_HOME: join(home, ".config"),
        PI_CODING_AGENT_DIR: join(home, ".pi-agent"),
        PI_OFFLINE: "1",
      },
    },
  );

  assert.equal(result.status, 0, `${result.stdout}\n${result.stderr}`);
  assert.doesNotMatch(`${result.stdout}\n${result.stderr}`, /Failed to load extension/u);
});

test("all package extensions load together without global registration conflicts", { skip: !hasPi }, async () => {
	const packageJson = JSON.parse(await readFile(join(repositoryRoot, "package.json"), "utf8")) as {
		dependencies: Record<string, string>;
		files: string[];
		pi: { extensions: string[] };
		allowScripts: Record<string, boolean>;
	};
	assert.ok(
		packageJson.pi.extensions.includes("./extensions/codegraph.ts"),
		"the bundle must expose the native codegraph_explore tool",
	);
	assert.ok(
		packageJson.pi.extensions.includes("./pi-web-search/index.ts"),
		"the bundle must load the unified pi-web-search tools",
	);
	assert.equal(packageJson.dependencies["pi-web-search"], "file:./pi-web-search");
	assert.equal(
		packageJson.pi.extensions.includes("./extensions/plugin-init.ts"),
		false,
		"the retired plugin initializer command must not be loaded",
	);
	assert.ok(
		packageJson.pi.extensions.includes("./pi-hermes-memory/src/index.ts"),
		"the bundle must load the vendored Hermes memory extension",
	);
	assert.ok(
		packageJson.pi.extensions.includes("./pi-minimal-footer/index.ts"),
		"the bundle must load the locally maintained minimal footer",
	);
	assert.equal(packageJson.dependencies["pi-compaction"], "file:./pi-compaction");
	assert.ok(packageJson.files.includes("pi-compaction"), "the packed bundle must include maintained pi-compaction source");
	assert.ok(
		packageJson.pi.extensions.includes("./pi-compaction/index.ts"),
		"the bundle must load the unified pi-compaction authority",
	);
	assert.equal(packageJson.dependencies["pi-condense"], undefined);
	assert.equal(packageJson.dependencies["@ogulcancelik/pi-codex-compaction"], undefined);
	assert.equal(packageJson.dependencies["pi-context-view"], undefined);
	assert.ok(packageJson.pi.extensions.includes("./extensions/context-view.ts"));
	assert.ok(
		packageJson.pi.extensions.indexOf("./pi-compaction/index.ts") <
			packageJson.pi.extensions.indexOf("./extensions/context-view.ts"),
		"the context observer must load after the compaction authority",
	);
	assert.ok(
		packageJson.pi.extensions.indexOf("./pi-compaction/index.ts") <
			packageJson.pi.extensions.indexOf("./pi-minimal-footer/index.ts"),
		"the footer must load after the compaction metrics service",
	);
	assert.ok(packageJson.pi.extensions.includes("./pi-ssh/index.ts"), "the bundle must load the locally maintained SSH extension");
	assert.equal(packageJson.dependencies["pi-ssh"], "file:./pi-ssh");
	assert.match(packageJson.dependencies.ssh2 ?? "", /^\d+\.\d+\.\d+$/, "the packed bundle must install pi-ssh's runtime transport at an exact version");
	assert.match(packageJson.dependencies.jiti ?? "", /^\d+\.\d+\.\d+$/, "the packed helper must load local TypeScript outside Pi at an exact version");
	assert.ok(packageJson.files.includes("pi-ssh"), "the packed bundle must include the locally maintained SSH source");
	assert.ok(packageJson.files.includes("configure.sh"), "the packed bundle must include the search/SSH config helper");
	assert.ok(packageJson.pi.extensions.includes("./pi-ask-user/index.ts"), "the bundle must load pi-ask-user");
	assert.equal(packageJson.dependencies["pi-ask-user"], "file:./pi-ask-user");
	assert.ok(packageJson.files.includes("pi-ask-user"), "the packed bundle must include pi-ask-user source");
	assert.ok(
		packageJson.pi.extensions.includes("./pi-worktree/index.ts"),
		"the bundle must load the locally maintained worktree commands",
	);
	assert.equal(packageJson.dependencies["pi-worktree"], "file:./pi-worktree");
	assert.ok(packageJson.files.includes("pi-worktree"), "the packed bundle must include pi-worktree source");
	const chromeExtension = "./pi-chrome/extensions/chrome-profile-bridge/index.ts";
	assert.equal(packageJson.dependencies["pi-chrome"], "file:./pi-chrome", "the browser bridge must use the locally maintained source");
	assert.ok(packageJson.files.includes("pi-chrome"), "the packed bundle must include the locally maintained pi-chrome source");
	assert.ok(packageJson.pi.extensions.includes(chromeExtension), "the bundle must load the local Chrome profile bridge directly");
	assert.ok(
		packageJson.pi.extensions.indexOf(chromeExtension) <
			packageJson.pi.extensions.indexOf("./pi-tool-search/extensions/index.ts"),
		"pi-chrome must register before Tool Search catalogs its authorized tools",
	);
	const permissionPolicySource = await readFile(
		join(repositoryRoot, "config", "pi-permission-policy.jsonc"),
		"utf8",
	);
	const hardGuardSource = await readFile(
		join(repositoryRoot, "config", "pi-permission-hard-guards.jsonc"),
		"utf8",
	);
	const stripLineComments = (source: string): string => source.replace(/^\s*\/\/.*$/gmu, "");
	const permissionConfig = JSON.parse(stripLineComments(permissionPolicySource)) as {
		authorizerChain: string[];
		permission: Record<string, unknown>;
	};
	const hardGuardConfig = JSON.parse(stripLineComments(hardGuardSource)) as {
		permission: { path?: Record<string, string>; bash: Record<string, string> };
	};
	assert.equal(permissionConfig.permission.ssh_connect, "ask", "SSH connection must enter the permission gate");
	assert.equal(permissionConfig.permission.ssh_cd, "ask", "remote workspace changes must enter the permission gate");
	assert.deepEqual(permissionConfig.authorizerChain, ["auto-review"], "SSH connection asks must reach AutoReview");
	assert.equal(permissionConfig.permission.Agent, "allow", "launching a subagent is side-effect free; child actions stay gated");
	assert.equal(permissionConfig.permission.get_subagent_result, "allow");
	assert.equal(permissionConfig.permission.steer_subagent, "allow");
	assert.equal(hardGuardConfig.permission.path, undefined, "sensitive paths must not be hard-denied by default");
	assert.equal(hardGuardConfig.permission.bash["rm -rf /"], "deny");
	assert.equal(
		packageJson.pi.extensions.some((entry) => entry.includes("pi-permission-auto-review")),
		false,
		"AutoReview must be integrated instead of loaded as a second extension",
	);
	assert.ok(
		packageJson.pi.extensions.indexOf("./extensions/permission-system.ts") <
			packageJson.pi.extensions.indexOf("./pi-ssh/index.ts"),
		"the permission service must load before pi-ssh registers its permission bridge",
	);
	assert.ok(
		packageJson.pi.extensions.indexOf("./pi-ssh/index.ts") <
			packageJson.pi.extensions.indexOf("./pi-tool-search/extensions/index.ts"),
		"pi-ssh tools must register before Tool Search builds its catalog",
	);
	assert.ok(
		packageJson.pi.extensions.indexOf("./pi-ask-user/index.ts") <
			packageJson.pi.extensions.indexOf("./pi-tool-search/extensions/index.ts"),
		"ask_user_question must register before Tool Search builds its catalog",
	);
	assert.ok(
		packageJson.pi.extensions.includes("./pi-notify/src/index.ts"),
		"the bundle must load the locally maintained Kitty notification extension",
	);
	assert.equal(packageJson.dependencies["@smoose/pi-notify"], "file:./pi-notify");
	assert.ok(
		packageJson.files.includes("pi-notify"),
		"the packed bundle must include the locally maintained notification source",
	);
	assert.equal(packageJson.dependencies["@ogulcancelik/pi-minimal-footer"], "file:./pi-minimal-footer");
	assert.equal(packageJson.dependencies["@tintinweb/pi-subagents"], "file:./pi-subagents");
	assert.ok(packageJson.pi.extensions.includes("./extensions/subagents.ts"));
	assert.ok(
		packageJson.pi.extensions.indexOf("./extensions/permission-system.ts") <
			packageJson.pi.extensions.indexOf("./extensions/subagents.ts"),
		"the permission service must load before the subagents wrapper injects it as a mandatory child extension",
	);
	assert.ok(
		packageJson.pi.extensions.indexOf("./extensions/subagents.ts") <
			packageJson.pi.extensions.indexOf("./pi-tool-search/extensions/index.ts"),
		"the subagent orchestration tools must register before Tool Search builds its catalog",
	);
	assert.ok(
		packageJson.pi.extensions.includes("./pi-hermes-memory/src/index.ts"),
		"the bundle must load the locally maintained Hermes memory extension",
	);
	// extensions/system-prompt.ts is the bundle's single system-prompt owner and
	// must run after every tool-registration extension (including Tool Search)
	// so it sees the complete tool set and any contributed sections.
	assert.equal(
		packageJson.pi.extensions.at(-1),
		"./extensions/system-prompt.ts",
		"the single system-prompt owner must be the last loaded extension",
	);
	assert.ok(
		packageJson.pi.extensions.includes("./extensions/context-mode.ts"),
		"Context Mode must load through the bundle's prompt-guarded wrapper",
	);
	assert.equal(
		packageJson.pi.extensions.some((entry) => entry.includes("context-mode/build/")),
		false,
		"the raw Context Mode adapter must not be loaded alongside the wrapper",
	);
	assert.equal(
		packageJson.pi.extensions.includes("./extensions/system-prompt-cover.ts"),
		false,
		"the retired system-prompt cover must not be loaded",
	);
	assert.equal(
		packageJson.pi.extensions.includes("./extensions/tool-routing.ts"),
		false,
		"the retired tool-routing extension must not be loaded",
	);
	for (const retired of [
		"extensions/system-prompt-cover.ts",
		"extensions/system-prompt-cover-config.ts",
		"extensions/tool-routing.ts",
	]) {
		assert.equal(
			existsSync(join(repositoryRoot, retired)),
			false,
			`${retired} was superseded by extensions/system-prompt.ts and must be deleted`,
		);
	}
	assert.equal(packageJson.dependencies["pi-hermes-memory"], "file:./pi-hermes-memory");
	assert.ok(
		packageJson.files.includes("pi-hermes-memory"),
		"the packed bundle must include the locally maintained Hermes memory source",
	);
	assert.ok(
		packageJson.pi.extensions.indexOf("./pi-hermes-memory/src/index.ts") <
			packageJson.pi.extensions.indexOf("./pi-compaction/index.ts"),
		"the memory extension must register its session_before_compact flush before the compaction authority can cancel the event",
	);
	assert.equal(
		packageJson.pi.extensions.some((entry) => entry.includes("hippo-memory-pi") || entry.includes("the-forge-flow")),
		false,
		"retired Hippo and third-party memory extensions must not be loaded",
	);
	assert.equal(packageJson.dependencies["@the-forge-flow/hippo-memory-pi"], undefined);
	assert.equal(packageJson.dependencies["better-sqlite3"], undefined);
	// allowScripts must approve exactly the root lockfile's better-sqlite3
	// build — and nothing else. pi-hermes-memory's own lockfile carries a
	// nested major that ships N-API prebuilds and needs no approval entry.
	const rootLock = JSON.parse(await readFile(join(repositoryRoot, "package-lock.json"), "utf8")) as {
		packages: Record<string, { version?: string }>;
	};
	const hermesLock = JSON.parse(await readFile(join(repositoryRoot, "pi-hermes-memory", "package-lock.json"), "utf8")) as {
		packages: Record<string, { version?: string }>;
	};
	const rootSqliteVersion = rootLock.packages["node_modules/better-sqlite3"]?.version;
	const hermesSqliteVersion = hermesLock.packages["node_modules/better-sqlite3"]?.version;
	assert.match(rootSqliteVersion ?? "", /^\d+\.\d+\.\d+$/, "the root lockfile must pin a root-level better-sqlite3");
	assert.match(hermesSqliteVersion ?? "", /^\d+\.\d+\.\d+$/, "the Hermes lockfile must pin its own better-sqlite3");
	assert.deepEqual(
		Object.keys(packageJson.allowScripts).filter((key) => key.startsWith("better-sqlite3@")),
		[`better-sqlite3@${rootSqliteVersion}`],
		"allowScripts must approve exactly the root lockfile's better-sqlite3 build",
	);
	assert.equal(
		packageJson.allowScripts[`better-sqlite3@${hermesSqliteVersion}`],
		undefined,
		`Hermes uses better-sqlite3 ${hermesSqliteVersion} N-API prebuilds, so no extra install-script approval is required`,
	);
	assert.equal(packageJson.dependencies["@sinclair/typebox"], undefined);
	const home = await mkdtemp(join(tmpdir(), "my-pi-extension-load-"));
	const mockBin = join(home, "bin");
	await mkdir(mockBin, { recursive: true });
	const args = ["--no-extensions"];
	for (const entry of packageJson.pi.extensions) args.push("-e", resolve(repositoryRoot, entry));
	args.push("--mode", "rpc");

	const loadEnvironment = {
		...process.env,
		HOME: home,
		XDG_CONFIG_HOME: join(home, ".config"),
		PI_CODING_AGENT_DIR: join(home, ".pi-agent"),
		PATH: `${mockBin}:${process.env.PATH ?? ""}`,
		PI_OFFLINE: "1",
	};
	const runBundle = () => spawnSync("pi", args, {
		encoding: "utf8",
		timeout: 60_000,
		env: loadEnvironment,
	});
	const result = runBundle();

	assert.equal(result.status, 0, `${result.stdout}\n${result.stderr}`);
	assert.doesNotMatch(`${result.stdout}\n${result.stderr}`, /Failed to load extension|conflicts with/u);
});