mirror of
https://bitbucket.org/siakitem/my-pi.git
synced 2026-10-26 18:55:22 +00:00
AutoReview: - 审查器回到 Codex Guardian 风格的对话式审查,默认跟随会话当前主模型 (每次审查实时读取 ctx.model);provider/model 必须同时设置才固定审查 模型,只设其一视为配置错误并转人工。 - 结论只通过 approve / reject 两个工具给出,参数仅 reason;不强制 toolChoice,正文文本(即使是合法 JSON)一律忽略。 - approve 自动放行;reject 转人工并在弹窗显示理由(标注模型生成)。 超时、Provider 错误、截断、未调用工具、多次调用、参数无效等异常同样 转人工,并附固定的系统说明;用户按 Esc 中止时直接拒绝。 - 模型调用改为 modelRegistry.streamSimple(...).result():Pi 1.3.0 面向 扩展的 ModelRegistry 没有 completeSimple,原写法在真实环境中每次都会 转人工。 - 对话记录保留可信度标注;工具结果在有更短的 pi-compaction 摘要时替换 为摘要;token 估算改为非 ASCII 字符按 1 token 计;预算可配置。 - 同一条用户消息内完全相同的请求只缓存 approve 结论。 - 默认 reasoning low、总超时 30 秒、最多 2 次尝试、maxOutputTokens 4000。 删除: - 未发布过的 TypeSafe Jev 分类器实现、DenialCircuitBreaker。 - 整个 annotator 机制(model-explanation、注册表、registerAnnotator、 provider-timeout);annotators 配置键保留为已弃用并忽略,避免旧配置 被拒绝。 测试: - 新增 reviewer / transcript / 弹窗说明 / 默认配置测试;清理重复、恒真 或只测实现细节的旧测试。 - 使用 deepseek-v4.1-flash 实测 5 个场景各 5 次,25 次结论全部符合预期。 Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
147 lines
5.4 KiB
TypeScript
147 lines
5.4 KiB
TypeScript
import { beforeEach, describe, expect, it, vi } from "vitest";
|
|
import type { RegisteredChildDetector } from "#src/authority/subagent-detection";
|
|
import type { PermissionsService } from "#src/service";
|
|
import { PermissionServiceLifecycle } from "#src/service-lifecycle";
|
|
|
|
import { makeCtx } from "#test/helpers/handler-fixtures";
|
|
|
|
// ── module stubs ───────────────────────────────────────────────────────────
|
|
|
|
const mockIsRegisteredChild = vi.fn<(ctx: unknown) => boolean>();
|
|
const mockPublishPermissionsService = vi.hoisted(() => vi.fn<() => void>());
|
|
const mockUnpublishPermissionsService = vi.hoisted(() => vi.fn<() => void>());
|
|
const mockEmitReadyEvent = vi.hoisted(() => vi.fn<() => void>());
|
|
|
|
vi.mock("#src/service", () => ({
|
|
publishPermissionsService: mockPublishPermissionsService,
|
|
unpublishPermissionsService: mockUnpublishPermissionsService,
|
|
}));
|
|
vi.mock("#src/permission-events", () => ({
|
|
emitReadyEvent: mockEmitReadyEvent,
|
|
}));
|
|
|
|
// ── helpers ────────────────────────────────────────────────────────────────
|
|
|
|
function makeService(): PermissionsService {
|
|
return {
|
|
checkPermission: vi.fn(),
|
|
getToolPermission: vi.fn(),
|
|
registerToolInputFormatter: vi.fn(),
|
|
registerToolAccessExtractor: vi.fn(),
|
|
registerAuthorizer: vi.fn(),
|
|
};
|
|
}
|
|
|
|
function makeDetection(): RegisteredChildDetector {
|
|
return { isRegisteredChild: mockIsRegisteredChild };
|
|
}
|
|
|
|
function makeLifecycle(overrides?: { subscriptions?: (() => void)[] }) {
|
|
const service = makeService();
|
|
const detection = makeDetection();
|
|
const events = { emit: vi.fn(), on: vi.fn() };
|
|
const subscriptions = overrides?.subscriptions ?? [];
|
|
const lifecycle = new PermissionServiceLifecycle(
|
|
service,
|
|
detection,
|
|
events,
|
|
subscriptions,
|
|
);
|
|
return { lifecycle, service, detection, events, subscriptions };
|
|
}
|
|
|
|
beforeEach(() => {
|
|
mockIsRegisteredChild.mockReset();
|
|
mockIsRegisteredChild.mockReturnValue(false);
|
|
mockPublishPermissionsService.mockReset();
|
|
mockUnpublishPermissionsService.mockReset();
|
|
mockEmitReadyEvent.mockReset();
|
|
});
|
|
|
|
// ── activate ──────────────────────────────────────────────────────────────
|
|
|
|
describe("activate", () => {
|
|
it("publishes the service for a non-child session", () => {
|
|
const ctx = makeCtx();
|
|
const { lifecycle, service } = makeLifecycle();
|
|
mockIsRegisteredChild.mockReturnValue(false);
|
|
lifecycle.activate(ctx);
|
|
expect(mockPublishPermissionsService).toHaveBeenCalledWith(service);
|
|
});
|
|
|
|
it("skips publishing for a registered child session", () => {
|
|
const ctx = makeCtx();
|
|
const { lifecycle } = makeLifecycle();
|
|
mockIsRegisteredChild.mockReturnValue(true);
|
|
lifecycle.activate(ctx);
|
|
expect(mockPublishPermissionsService).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("always emits the ready event, even for a child session", () => {
|
|
const ctx = makeCtx();
|
|
const { lifecycle, events } = makeLifecycle();
|
|
mockIsRegisteredChild.mockReturnValue(true);
|
|
lifecycle.activate(ctx);
|
|
expect(mockEmitReadyEvent).toHaveBeenCalledWith(events);
|
|
});
|
|
|
|
it("emits ready after publishing the service", () => {
|
|
const ctx = makeCtx();
|
|
const order: string[] = [];
|
|
mockPublishPermissionsService.mockImplementation(() =>
|
|
order.push("publish"),
|
|
);
|
|
mockEmitReadyEvent.mockImplementation(() => order.push("ready"));
|
|
const { lifecycle } = makeLifecycle();
|
|
lifecycle.activate(ctx);
|
|
expect(order).toEqual(["publish", "ready"]);
|
|
});
|
|
|
|
it("consults the detector with ctx", () => {
|
|
const ctx = makeCtx();
|
|
const { lifecycle } = makeLifecycle();
|
|
lifecycle.activate(ctx);
|
|
expect(mockIsRegisteredChild).toHaveBeenCalledWith(ctx);
|
|
});
|
|
});
|
|
|
|
// ── teardown ──────────────────────────────────────────────────────────────
|
|
|
|
describe("teardown", () => {
|
|
it("calls each subscription unsubscribe function", () => {
|
|
const unsub1 = vi.fn();
|
|
const unsub2 = vi.fn();
|
|
const unsub3 = vi.fn();
|
|
const { lifecycle } = makeLifecycle({
|
|
subscriptions: [unsub1, unsub2, unsub3],
|
|
});
|
|
lifecycle.teardown();
|
|
expect(unsub1).toHaveBeenCalledOnce();
|
|
expect(unsub2).toHaveBeenCalledOnce();
|
|
expect(unsub3).toHaveBeenCalledOnce();
|
|
});
|
|
|
|
it("unpublishes the service after running subscriptions", () => {
|
|
const order: string[] = [];
|
|
const unsub = vi.fn(() => order.push("unsub"));
|
|
mockUnpublishPermissionsService.mockImplementation(() =>
|
|
order.push("unpublish"),
|
|
);
|
|
const { lifecycle } = makeLifecycle({ subscriptions: [unsub] });
|
|
lifecycle.teardown();
|
|
expect(order).toEqual(["unsub", "unpublish"]);
|
|
});
|
|
|
|
it("passes the service to unpublishPermissionsService", () => {
|
|
const { lifecycle, service } = makeLifecycle();
|
|
lifecycle.teardown();
|
|
expect(mockUnpublishPermissionsService).toHaveBeenCalledWith(service);
|
|
});
|
|
|
|
it("works with no subscriptions", () => {
|
|
const { lifecycle } = makeLifecycle({ subscriptions: [] });
|
|
expect(() => lifecycle.teardown()).not.toThrow();
|
|
expect(mockUnpublishPermissionsService).toHaveBeenCalledOnce();
|
|
});
|
|
});
|