mirror of
https://bitbucket.org/siakitem/my-pi.git
synced 2026-10-26 18:55:22 +00:00
AutoReview: - 审查器回到 Codex Guardian 风格的对话式审查,默认跟随会话当前主模型 (每次审查实时读取 ctx.model);provider/model 必须同时设置才固定审查 模型,只设其一视为配置错误并转人工。 - 结论只通过 approve / reject 两个工具给出,参数仅 reason;不强制 toolChoice,正文文本(即使是合法 JSON)一律忽略。 - approve 自动放行;reject 转人工并在弹窗显示理由(标注模型生成)。 超时、Provider 错误、截断、未调用工具、多次调用、参数无效等异常同样 转人工,并附固定的系统说明;用户按 Esc 中止时直接拒绝。 - 模型调用改为 modelRegistry.streamSimple(...).result():Pi 1.3.0 面向 扩展的 ModelRegistry 没有 completeSimple,原写法在真实环境中每次都会 转人工。 - 对话记录保留可信度标注;工具结果在有更短的 pi-compaction 摘要时替换 为摘要;token 估算改为非 ASCII 字符按 1 token 计;预算可配置。 - 同一条用户消息内完全相同的请求只缓存 approve 结论。 - 默认 reasoning low、总超时 30 秒、最多 2 次尝试、maxOutputTokens 4000。 删除: - 未发布过的 TypeSafe Jev 分类器实现、DenialCircuitBreaker。 - 整个 annotator 机制(model-explanation、注册表、registerAnnotator、 provider-timeout);annotators 配置键保留为已弃用并忽略,避免旧配置 被拒绝。 测试: - 新增 reviewer / transcript / 弹窗说明 / 默认配置测试;清理重复、恒真 或只测实现细节的旧测试。 - 使用 deepseek-v4.1-flash 实测 5 个场景各 5 次,25 次结论全部符合预期。 Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
96 lines
3.2 KiB
TypeScript
96 lines
3.2 KiB
TypeScript
/**
|
|
* Tests that handleInput emits permissions:decision events for skill input gates.
|
|
*/
|
|
import { describe, expect, it, vi } from "vitest";
|
|
|
|
import type { AskEscalator } from "#src/authority/authorizer-selection";
|
|
import { DECIDED_BY_HUMAN } from "#test/helpers/decision-fixtures";
|
|
import {
|
|
getDecisionEvents,
|
|
makeCheckResult,
|
|
makeCtx,
|
|
makeHandler,
|
|
} from "#test/helpers/handler-fixtures";
|
|
|
|
// ── helpers ────────────────────────────────────────────────────────────────
|
|
|
|
/** Build a checkPermission mock returning a skill-surface result. */
|
|
function makeSkillCheckPermission(state: "allow" | "deny" | "ask") {
|
|
return vi.fn().mockReturnValue(
|
|
makeCheckResult({
|
|
state,
|
|
toolName: "skill",
|
|
source: "skill",
|
|
origin: "global",
|
|
matchedPattern: "*",
|
|
}),
|
|
);
|
|
}
|
|
|
|
// ── tests ──────────────────────────────────────────────────────────────────
|
|
|
|
describe("handleInput decision events — skill gate", () => {
|
|
it("does not emit when input is not a skill invocation", async () => {
|
|
const { handler, events } = makeHandler();
|
|
await handler.handleInput({ text: "hello world" }, makeCtx());
|
|
expect(getDecisionEvents(events)).toHaveLength(0);
|
|
});
|
|
|
|
it("emits allow with policy_allow for an allowed skill", async () => {
|
|
const { handler, events } = makeHandler({
|
|
session: { checkPermission: makeSkillCheckPermission("allow") },
|
|
});
|
|
await handler.handleInput({ text: "/skill:librarian" }, makeCtx());
|
|
|
|
const decisions = getDecisionEvents(events);
|
|
expect(decisions).toHaveLength(1);
|
|
expect(decisions[0]).toMatchObject({
|
|
surface: "skill",
|
|
value: "librarian",
|
|
result: "allow",
|
|
resolution: "policy_allow",
|
|
});
|
|
});
|
|
|
|
it("emits deny with policy_deny for a denied skill", async () => {
|
|
const { handler, events } = makeHandler({
|
|
session: { checkPermission: makeSkillCheckPermission("deny") },
|
|
});
|
|
await handler.handleInput({ text: "/skill:restricted" }, makeCtx());
|
|
|
|
const decisions = getDecisionEvents(events);
|
|
expect(decisions).toHaveLength(1);
|
|
expect(decisions[0]).toMatchObject({
|
|
surface: "skill",
|
|
value: "restricted",
|
|
result: "deny",
|
|
resolution: "policy_deny",
|
|
});
|
|
});
|
|
|
|
it("emits a decision event on the escalate path", async () => {
|
|
const { handler, events } = makeHandler({
|
|
session: {
|
|
checkPermission: makeSkillCheckPermission("ask"),
|
|
},
|
|
prompter: {
|
|
escalate: vi.fn<AskEscalator["escalate"]>().mockResolvedValue({
|
|
approved: true,
|
|
state: "approved",
|
|
decidedBy: DECIDED_BY_HUMAN,
|
|
}),
|
|
},
|
|
});
|
|
await handler.handleInput({ text: "/skill:explorer" }, makeCtx());
|
|
|
|
const decisions = getDecisionEvents(events);
|
|
expect(decisions).toHaveLength(1);
|
|
expect(decisions[0]).toMatchObject({
|
|
surface: "skill",
|
|
value: "explorer",
|
|
result: "allow",
|
|
resolution: "user_approved",
|
|
});
|
|
});
|
|
});
|